Changeset 16 for branches/t3e-tools/t3q/src/org/etsi/t3q/visitor/QualityChecker.java

Timestamp:

08/06/10 16:40:42 (14 years ago)

Author:

phdmakk

Message:

+ rt guideline prototype implementation

File:

• branches/t3e-tools/t3q/src/org/etsi/t3q/visitor/QualityChecker.java (modified) (1 diff)

branches/t3e-tools/t3q/src/org/etsi/t3q/visitor/QualityChecker.java

@@ -2458 +2458 @@
         }
 
+        
+        //TODO: temporary duplicate of the above
+        //- above needs refactoring
+        //- this needs to be separated in a realtime checker
+        public void checkWaitStatementPrecededByLog(LocationAST node) {
+                // TODO: no more function statement or defs
+                // TODO: fixed issue with statement blocks
+
+                // Fixed: currently based on SetLocalVerdict node,
+                // consider starting at the fail or inconc node instead, checking
+                // whether it is
+                // within a set verdict context and proceed from there
+                // fix: it is specific to the set verdict and not to inconc or fail
+                // alone
+
+                boolean problemOccured = false;
+                LocationAST parentNode = LocationAST.resolveParentsUntilType(node,
+                                new int[] { TTCN3ParserTokenTypes.FunctionStatement });
+                if (parentNode == null) {
+                        this.getLoggingInterface().logFix(node.getLine(),
+                                        node.getEndLine(),
+                                        MessageClass.LOGGING,
+                                        "Cannot resolve the parent node",
+                                        "5.4, " + MiscTools.getMethodName());
+                        return;
+                }
+
+                int functionStatementOrDefsVisitedCount = visitor.getFunctionStatementOrDefNodes()
+                                                                                                                        .size();
+                if (parentNode == visitor.getFunctionStatementOrDefNodes()
+                                                                        .get(functionStatementOrDefsVisitedCount - 1)) {
+
+                        int i = functionStatementOrDefsVisitedCount - 2;
+                        if (i >= 0) {
+                                LocationAST next = null;
+                                // skip semicolons
+                                next = visitor.getFunctionStatementOrDefNodes()
+                                                                .get(i)
+                                                                .getNextSibling();
+
+                                while ((next != null)
+                                                && (next.getType() == TTCN3ParserTokenTypes.SemiColon)) {
+                                        next = next.getNextSibling();
+                                }
+
+                                if (next == parentNode) {
+                                        LocationAST resultNode = (LocationAST) ASTUtil.findChild(visitor.getFunctionStatementOrDefNodes()
+                                                                                                                                                                        .get(i),
+                                                        TTCN3ParserTokenTypes.LogStatement);
+                                        if (resultNode == null) {
+                                                problemOccured = true;
+                                        }
+                                } else {
+                                        problemOccured = true;
+                                }
+                        } else {
+                                problemOccured = true;
+                        }
+                }
+
+                if (problemOccured) {
+                        this.getLoggingInterface()
+                                .logWarning(node.getLine(),
+                                                node.getEndLine(),
+                                                MessageClass.LOGGING,
+                                                "No log statement precedes a wait statement!",
+                                                "RT.X.X, " + MiscTools.getMethodName());
+                }
+        }
+        
         // -------------------------------------------------------------------------------------------